Repository navigation
Conversation
Jakfut
added
AI
Nikolay-Sitnikov
self-requested a review
October 28, 2026 21:27
Algent
added
the
Ongoing Freeze - Do NOT Merge
Dream-Master
removed
the
Ongoing Freeze - Do NOT Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FMLProxyPacket sends the buffer untrimmed, a bunch of mods use this incorrectly, causing the packet to pad zeros until the next power of 2, at least 256 bytes.
I moved it to a Hodgepodge fix because too many mods are using this incorrectly
GTNewHorizons/GT5-Unofficial#8596
GTNewHorizons/CubicChunks1710#155
Result
In my CubicChunks UHV world this cut total network traffic by one third, and GregTech traffic by halve, I have not measured the change without CubicChunks
Checklist